Ah, the vagaries of men's fashion! I mourn the demise of men's short shorts as everyday casual attire. ;-)
The 70s and 80s were great for man watching, if you were a leg man, I guess. Lol.
I'd be interested one day to see some kind of exploration of why men's fashion started to become much more "modest" in the 1990s.
Right up through the 80s, I often wore very short shorts, and when the shorts in question were my OP brand shorts, they were also skin tight.
But I wore them in public without a second thought, along with my straight-guy friends.
I really only noticed things had changed in the mid 90s when a gay guy cruised me, saying something like, "It's obvious from those shorts that you're playing for my team."
This was in middle-class suburban America, and since I'd been a bit isolated in NYC gay enclaves, I hadn't noticed that straight men weren't wearing short shorts anymore!